Fix bug: Support for arrays in IsListNotNullOrEmptyConverter/IsListNotNullOrEmptyConverter#2396
Merged
TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom Dec 19, 2024
Conversation
Modified IsListNotNullOrEmptyConverterTests: - Empty List<string> now returns true. - Added empty array (Array.Empty<string>()) returning true. - List<string> with "TestValue" now returns false. - Null value now returns true. - Enumerable.Range(1, 3) now returns false. Added new test cases: - Empty array (Array.Empty<string>()) returning true. - Array with "TestValue" returning false. Updated IsListNullOrEmpty method: - Check if enumerator is IDisposable before disposing.
VladislavAntonyuk
approved these changes
Dec 19, 2024
TheCodeTraveler
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added check that enumerator is disposable before calling dispose, allowing support for ArrayEnumerator
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information